Contact Us

Bad - Using a plain email address that it will be crawled and made use of easily​

​Contact Us

Good - Using an encoded email address​​

Note: If you use Wordpress, use the Email Encoder Bundle plugin to help you encode email addresses easily.

We have a program called SSW CodeAuditor to check for this rule.​
We have a program called SSW Link​Auditor to check for this rule.​​​

As a rule of thumb, no methods should be greater than 50 lines of code. Long-winded methods are the bane of any developer and should be avoided at all costs. Instead, a method of 50 lines or more should be broken down into smaller functions.

​Ideally, you should keep design and code separate - otherwise, it will be difficult to maintain your application. Try to move all data access and business logic code into separate modules.

Bob Martin explains this best:

 

For Javascript / Typescript ​​

Google publishes a JavaScript style guide. 

Here are some key points:

• Use const or let – Not var 
  
• Use semicolons 
  
• Use arrow functions
  
• Use template strings 
  
• Use uppercase constants 
  
• Use single quotes
  

See 13 Noteworthy Points from Google’s JavaScript Style Guide​

For C# Java​​

See chapter 2: Meaningful Names Clean Code: A Handbook of Agile Software Craftsmanship​​

For SQL (not really relevant these days)​​

• SQL Server Object Naming Standard
• SQL Stored Procedure Naming Standard
• SQL Stored Procedure Formatting Standard 
• SQL Server Indexes Naming Standard 
  
• SQL Server Relationship Naming Standard 
• SQL Server Design Standards
  

Stage	Testing Description	Naming Convention
Alpha	Developer testing with project team	Northwind_v2-3_alpha.exe
Beta	Internal “Test Please" testing with non-project working colleagues	Northwind_v2-3_beta.exe
Production e.g.	When moving onto production, this naming convention is dropped	Northwind_v2-3.exe

​​

Note that this rule should apply to any file or folder that is on the web. This includes TFS Team Project names and SharePoint Pages.

extremeemailsversion1.2.doc
Extreme Emails version 1.2.doc

Figure - Bad Examples: filenames have spaces or dots

Extreme_Emails_v1_2.doc
ExtremeEmails_v1_2.doc

Figure – Good Examples: file names do not have spaces

UTS Short Course
Ignite Talk

Figure – Bad Examples: f​ile names have been published with spaces so the URLs look ugly and are hard to read

UTS Short Course
Ignite Talk

Figure – Good Examples: file names have no spaces so are much easier to read​​

​Generally, version numbering should begin at 0.1. Once the project has been approved for release by the client or tester, the version number will be incremented to 1.0. The numbering after the decimal point needs to be decided on and uniform. For example, 1.1 might have many bug fixes and a minor new feature, while 1.11 might only include one minor bug fix.​

1. nameof expressions - allows us to get the name of the type of object

   Now when we throw an exception, we can use the name of expressions feature to create robust code, which is more resistant to common mistakes when refactoring. This is achieved by reducing the amount of hard coding.

   As you can see, when in the past you would have to write the following code:

   (if customer.Address.ZipCode == null) throw new ArgumentNullException("ZipCode");

   Figure: Bad example - Amount of boiler plate code for a simple task 
   

   Now you only have write:

   (if customer.Address.ZipCode == null) throw new ArgumentNullException(nameof(customer.Address.ZipCode));

   Figure: Good example - The same functionality as the Bad Example in a single line of code
   The benefit of this change is when refactoring our code, we don't need to worry about searching for magic strings. Which common slip through the cracks and lead to confusing error messages.
2. String Interpolation - greatly reduces the amount of boilerplate code required when working with strings

Formatting strings on the fly was previously a task which required a stack of boilerplate code. In the Visual Studio 2015, we can use the smart String Interpolation feature. Not only does this feature reduce the amount of code we have to write, it also improves code readability.

For example, before C# 6, we would write:

var s = String.Format("Profit is ${0} this year", p.TotalEarnings - p.Totalcost);

Figure: Bad example - Using the string format make the code difficult to read


Now we are able to:

var s = "Profit is ${p.TotalEarnings - p.Totalcost} this year";

Figure: Good example - Very human readable code


As can be seen above by making use of the new String Interpolation feature, the understandability of your code is greatly improved.

3. ​Null-conditional operators - makes checking for null as easy as inserting a single question mark

   This great new feature has had a raft of positive reactions from developers. The new Null-conditional operators feature boils down all of the previously laborious clunky code into a single question mark.
   

   For example, previously we would of had to write a chunk of code to achieve a simple task

   if(customers.Length != null) { int length = customers.Length; } else { int length = 0; }

   Figure: Bad example - Fragile code

   Now we are able to replace that chunk of code with a single line

   int length = customers?.Length ?? 0;

   Figure: Good example - Robust code
   

   The promise In short, these new features will save you time, and help you write cleaner, more robust code - what's not to love?

​https://github.com/StyleCop/StyleCop ​​

​https://marketplace.visualstudio.com/items?itemName=VisualStudioPlatformTeam.MicrosoftCodeAnalysis2017​

​Private Sub Command0_Click()
Dim dteTodayDate As Date
Dim intRoutesPerDay As Integer
Dim intRoutesToday As Integer
Dim dblWorkLoadToday As Double
dblWorkLoadToday = Date.Now()
.
....many lines of code...
.
intRoutesPerDay = 2
End Sub

Figure: Bad example

Private Sub Command0_Click()
Dim dteTodayDate As Date
dteTodayDate = Date.Now()
.
....many lines of code...
.
Dim intRoutesPerDay As Integer
intRoutesPerDay = 2
.
....continuing code...
.End Sub

​Figure: Good example​​

​if (ProductName == null) ProductName = string.Empty; if (ProductVersion == null)
ProductVersion = string.Empty; if (StackTrace == null) StackTrace = string.Empty;

​​​Figure: Ba​d Example

if (ProductName == null)
{
ProductName = string.Empty;
}
if (ProductVersion == null)
{
ProductVersion = string.Empty;
}
if (StackTrace == null)
{
StackTrace = string.Empty;
}

​Figure: Good Example

​

​if (!IsValid)
{
// handle no error
}
else
{
// handle error
}​

Figure: Bad e​xample​

if (IsValid)
{
// handle error
}
else
{
// handle no error
}

Figure: Good example​

if (!IsValid)
{
// handle error
}

​Figure: Another good example​

​string p2 = "\\My Documents\\My Files\\";

Figure: Bad example - Using "\\"

string p2 = @"\My Documents\My Files\";

Figure: Good example - Using @​​

​

Bad example - The connection string without Application Name

// Good Code - Application Name is added in the connection string.​

​​Good example - The connection string with Application Name​

​Imports System.Windows.Threading
Imports System.Threading
'''

''' base class for command implementations
''' This is a work around as standard MVVM commands
''' are not provided by default
'''

'''
Public MustInherit Class Command
Implements ICommand
Private m_dispatcher As Dispatcher
Protected Sub New()
If Not Application.Current Is Nothing Then
m_dispatcher = Application.Current.Dispatcher
Else
m_dispatcher = Dispatcher.CurrentDispatcher
End If
Debug.Assert(Not m_dispatcher Is Nothing)
End Sub
Public MustOverride Function CanExecute(ByVal parameter As Object) As Boolean Implements System.Windows.Input.ICommand.CanExecute
Public MustOverride Sub Execute(ByVal parameter As Object) Implements System.Windows.Input.ICommand.Execute
Public Event CanExecuteChanged(ByVal sender As Object, ByVal e As System.EventArgs) Implements System.Windows.Input.ICommand.CanExecuteChanged

Public Sub OnCanExecuteChanged()
If Not m_dispatcher.CheckAccess Then
m_dispatcher.Invoke(New ThreadStart(AddressOf OnCanExecuteChanged), DispatcherPriority.Normal)
Else
CommandManager.InvalidateRequerySuggested()
RaiseEvent CanExecuteChanged(Me, New EventArgs)
End If
End Sub
End Class

Figure: Bad example - The link to the suggestion should be in the comments​

​Imports System.Windows.Threading
Imports System.Threading
'''

''' base class for command implementations
''' This is a work around as standard MVVM commands
''' are not provided by default
''' http://www.ssw.com.au/ssw/Standards/BetterSoftwareSuggestions/WPF.aspx#EmbraseMVVM
'''

'''
Public MustInherit Class Command
Implements ICommand
Private m_dispatcher As Dispatcher
Protected Sub New()
If Not Application.Current Is Nothing Then
m_dispatcher = Application.Current.Dispatcher
Else
m_dispatcher = Dispatcher.CurrentDispatcher
End If
Debug.Assert(Not m_dispatcher Is Nothing)
End Sub
Public MustOverride Function CanExecute(ByVal parameter As Object) As Boolean Implements System.Windows.Input.ICommand.CanExecute
Public MustOverride Sub Execute(ByVal parameter As Object) Implements System.Windows.Input.ICommand.Execute
Public Event CanExecuteChanged(ByVal sender As Object, ByVal e As System.EventArgs) Implements System.Windows.Input.ICommand.CanExecuteChanged

Public Sub OnCanExecuteChanged()
If Not m_dispatcher.CheckAccess Then
m_dispatcher.Invoke(New ThreadStart(AddressOf OnCanExecuteChanged), DispatcherPriority.Normal)
Else
CommandManager.InvalidateRequerySuggested()
RaiseEvent CanExecuteChanged(Me, New EventArgs)
End If
End Sub
End Class

​Figure: Good example - Wh​​en you link to a suggestion everyone can find it and vote it up

​

​ private void AMControlMouseLeftButtonUp(object sender, MouseButtonEventArgs e)
{
var auc = (AMUserControl)sender;
var aucSessionId = auc.myUserControl.Tag;
// snip snip snip
}

Bad example​​​

private void AMControlMouseLeftButtonUp(object sender, MouseButtonEventArgs e)
{
var auc = sender as AMUserControl;
if (auc != null)
{
var aucSessionId = auc.myUserControl.Tag;
// snip snip snip
}
}

​Good example​

More info here: ​http://blog.gfader.com/2010/08/avoid-type-casts-use-operator-and-check.html

​public class Example
{
public double salary()
{
}
}

​​Figure: Bad Example - Method is empty​​​​​

​public class Sample
{
public double salary()
{
return 2500.00;
}
}

​Figure: G​ood Example - Method implements some code

public interface IDemo
{
void DoSomethingUseful();
void SomethingThatCanBeIgnored();
}
public class Demo : IDemo
{
public void DoSomethingUseful()
{
// no audit issues
Console.WriteLine("Useful");
}
// audit issues
public void SomethingThatCanBeIgnored()
{
}
}

​Figure: Bad Example - No Comment within empty code block

​​​public interface IDemo
{
void DoSomethingUseful();
void SomethingThatCanBeIgnored();
}
public class Demo : IDemo
{
public void DoSomethingUseful()
{
// no audit issues
Console.WriteLine("Useful");
}
// No audit issues
public void SomethingThatCanBeIgnored()
{
// stub for IDemo interface
}
}

​​​Figure: Good Example - Added comment within Empty Code block method of interface class

​

Private Sub Command0_Click()
If My.MySettings.Default.Backend = "Access" Then
'Call this code ie. SQL commands
Else
'Must be SQL Server
'Call this other code ie. Stored Proc
End If
.....processing code
End Sub

Figure: Bad example with If statement

Consider later on this code is updated... the programmer wishes to add an Oracle backend database option. So they modify the Backend property to include Oracle...

By using the above code, the wrong code will run because the above code assumes two possible situations. To avoid this problem, change the code to be defensive .g. Use an Else If statement (like below).

The user will then get a Logic Error and can report it to the programmer.​

Private Sub Command0_Click()
If My.MySettings.Default.Backend = "Access" Then
'Call this code ie. SQL
ElseIf My.MySettings.Default.Backend = "SQL Server" Then
'Call this other code ie. Stored Proc
Else
Throw New Exception( "Logic Error -- BackEnd is: "
& My.MySettings.Default.Backend)
End If
End Sub

Figure: Good example with If statement

When writing code to trap Logic Errors, use "Select Case" or "switch" statements to enhance readability. e.g. in VB.NET

Private Sub Command0_Click()
Select Case mDataset.Tables(0).Rows(0)("Key")
Case "1"
' Initialize the column list
strTempColumn = ""
Case "2"
' Ignore
End Select
.....processing code
End Sub

Figure: Bad example with Case statement in VB.NET

Private Sub Command0_Click()
Select Case mDataset.Tables(0).Rows(0)("Key")
Case "1"
' Initialize the column list
strTempColumn = ""
Case "2"
' IgnoreCase Else
Throw New Exception("Logic Error")
End Select
.....processing code
End Sub

Figure: Good example - Use 'Select Case' or 'Switch' statements to enhance readability when coding to find logic errors

private void btnOK_Click(object sender, EventArgs e)
{
rtbParaText.Clear();
var query =
from p in dc.GetTable()
select p.ParaID;
foreach (var result in query)
{
var query2 =
from t in dc.GetTable()
where t.ParaID == result
select t.ParaText;
rtbParaText.AppendText(query2.First() + "\r\n");
}
}

Bad Example: A UI method mixed with business logics

private void btnOK_Click(object sender, EventArgs e)
{
string paraText = Business.GetParaText();
rtbParaText.Clear();
rtbParaText.Add(paraText);
}

Good Example : Putting business logics into the business project, just call the relevant method when needed​​

private void RaiseUIUpdateBidButtonsRed()
{
if (UIUpdateBidButtonsRed != null)
{
UIUpdateBidButtonsRed();
}
}

Bad Code: Avoid "UI" in event names, an event is UI un-aware

​​

private void RaiseSelectedLotUpdated()
{
if (SelectedLotUpdated != null)
{
SelectedLotUpdated();
}
}

Good Code: We received an update on the currently selected item, change the UI correspondingly (or even better: use MVVM and data binding)

​

int DepartmentId = GetDepartmentId()
if(DepartmentId == 1)
{
// do something
}
else if(DepartmentId == 2)
{
// do something #2
}
else if(DepartmentId == 3)
{
// do something #3
}
else if(DepartmentId == 4)
{
// do something #4
}
else if(DepartmentId == 5)
{
// do something #5
}
else
{
// do something #6
}

Figure: Bad example of coding practice

​

int DepartmentId = GetDepartmentId()
switch(DepartmentId)
{
case 1:
// do something
break;
case 2:
// do something # 2
break;
case 3:
// do something # 3
break;
case 4:
// do something # 4
break;
case 1:
// do something # 5
break;
case 1:
// do something # 6
break;
default:
//Do something here
break;
}

Figure: Good example of coding practice which will result better performance

Further Reading: Speed Test: Switch vs If-Else-If​

​XmlDocument report = new XmlDocument();
XmlTextReader tr = new XmlTextReader(Configuration.LastReportPath);
report.Load(tr);

To perform validation:

XmlDocument report = new XmlDocument();
XmlTextReader tr = new XmlTextReader(Configuration.LastReportPath);
XmlValidatingReader reader = new XmlValidatingReader(tr);
report.Load(reader);

The XSD should be distributed in the same directory as the XML file and a relative path should be used:

... ​​

"Integrated Security=SSPI;Initial Catalog=SallyKnoxMedical;Data
Source=TUNA"

Figure: Bad Connection String

"Integrated Security=SSPI;Initial Catalog=SallyKnoxMedical;Data Source=TUNA;
Connect Timeout=5"​

Figure: Good Connection String with a 5-second connection timeout

Match MatchExpression(string input, string pattern) 

Figure: Bad - Method without member accessibility declared

private Match MatchExpression(string input, string pattern) 

Figure: Good - Method with member accessibility declared

We have a program called SSW Code Auditor to check for this rule.

Private Sub AssignRightToLeft()
'Validate Right
If lstParaRight.SelectedIndex >= 0 Then
'Validate Left
If lstParaLeft.SelectedIndex >= 0 Then
Dim paraID As String = lstParaRight.SelectedValue.ToString
Dim mParagraph As BusinessLayer.Paragraph = New Paragraph
mParagraph.MoveRight(paraID)
RefreshData()
End If
End If
End Sub 

Figure: Bad example - using nested if for validation

​

Private Sub AssignRightToLeft()
'Validate Right and Left
If lstParaRight.SelectedIndex = -1 Then Return
If lstParaLeft.SelectedIndex = -1 Then Return
Dim paraID As String = lstParaRight.SelectedValue.ToString
Dim mParagraph As BusinessLayer.Paragraph = New Paragraph
mParagraph.MoveRight(paraID)
RefreshData()
End If
End If
End Sub

Figure: Good example - using Exit Sub to exit early if invalid ​

​ public Action
< connectioninformation > ConnectionProblem;

Bad code​

public event Action
< connectioninformation > ConnectionProblem;

​​​Good code​​

1. Make sure one rule is enabled in code analysis and
   
2. One rule in StyleCop and
3. Get Code Auditor to zero

Related links:

• http://stackoverflow.com/questions/455269/refactoring-do-you-follow-the-boy-scout-rule​
• http://programmer.97things.oreilly.com/wiki/index.php/The_Boy_Scout_Rule​
  

Public ReadOnly Property Enable As Boolean Get Return true End Get End Property
Public ReadOnly Property Invoice As Boolean Get Return m_Invoice End Get End Property

Bad Example

Public ReadOnly Property Enabled As Boolean Get Return true End Get End Property
Public ReadOnly Property IsInvoiceSent As Boolean Get return m_IsInvoiceSent End
Get End Property

Good Example - Naming Convention for Boolean Property

We have a program called SSW Code Auditor to check for this rule.​

DialogResult diaResult = MessageBox.Show(this,
"The database is not valid." + Environment.NewLine + "Do you want to upgrade it? ",
"Tip",
MessageBoxButtons.YesNo,
MessageBoxIcon.Warning);

Bad Example: "Environment.NewLine" isn't at the end of the line

DialogResult diaResult = MessageBox.Show(this,
"The database is not valid." + Environment.NewLine
+ "Do you want to upgrade it? ",
"Tip",
MessageBoxButtons.YesNo,
MessageBoxIcon.Warning);

Good Example:  "Environment.NewLine" is at the end of the line

​​

return string.Join(Environment.NewLine, paragraphs);

Good Example: ​"Environment.NewLine" is an exception for String.Join

​

​​​

Figure: Bad example - popup dialog at the end of a long process

Figure: Good example - show time taken in the status bar

​

​System.Text.StringBuilder myStringBuilder = new System.Text.StringBuilder();

Figure: Bad code - Long reference to object name​​

using System.Text;
...
...
StringBuilder myStringBuilder = new StringBuilder();

Figure: Good code - Import the namespace and remove the repeated System.Text reference

​

If you have ReSharper installed, you can let ReSharper take care of this for you:

Figure: Right click and select "Reformat Code..."

Figure: Make sure "Shorten references" is checked and click "Reformat"​

​​

Cursor cur;
try
{
...
cur = Cursor.Current; //Bad Code - initializing the variable inside the try block
Cursor.Current = Cursors.WaitCursor;
...
}
finally
{
Cursor.Current = cur;
}

Bad Example: Because of the initializing code inside the try block. If it failed on this line then you will get a NullReferenceException in Finally

Cursor cur = Cursor.Current; //Good Code - initializing the variable outside the try block
try
{
...
Cursor.Current = Cursors.WaitCursor;
...
}
finally
{
Cursor.Current = cur;
}

Good Example : Because the initializing code is outside the try​​​ block​​

​Private Sub ShowMyMessage()
MessageBox.Show("Are
you sure you want to delete the team project """ + strProjectName
+ """?" + Environment.NewLine + Environment.NewLine + "Warning:
Deleting a team project cannot be undone.", strProductName + "
" + strVersion(), MessageBoxButtons.YesNo, MessageBoxIcon.Warning, MessageBoxDefaultButton.Button2)

Figure: Bad example of MessageBox code format​

Private Sub ShowMyMessage()
MessageBox.Show( _
"Are you sure you want to delete the team project """ + strProjectName + """?"
_ + Environment.NewLine _ +
Environment.NewLine _ +
"Warning: Deleting a team project cannot be undone.", _
strProductName + " " + strVersion(), _
MessageBoxButtons.YesNo, _
MessageBoxIcon.Warning, _
MessageBoxDefaultButton.Button2)
End Sub

Figure: Good example of MessageBox code format​​

Public Enum ProjectLanguageEnum CSharp VisualBasic End Enum

Bad - Enum type is suffixed with the word "Enum"

Public Enum ProjectLanguage CSharp VisualBasic End Enum

Good - Enum type is not suffixed with the word "Enum"

We have a program called SSW Code Auditor to check for this rule.

​

​

Figure: Bad example

​

Figure: Good example​​

If using SQL Authentication
Server=DRAGON;Database=SSWData2005;Uid=SSWWebsite;Pwd=password;Application Name=SSWWebsite
If using Windows Authentication (Recommended)
Server=DRAGON;Database=SSWData2005;Integrated Security=True;Application Name=SSWWebsite

 ​Good example - The connection string with Application Name

"This is a workaround as per the suggestion 
"[URL]

Figure: Always add a URL to the suggestion that you are compensating for

​You should use named parameters under these scenarios:

• When there are 4 or more parameters
• When you make use of optional parameters
• If it makes more sense to order the parameters a certain way​​
  

Further Information

• The System.Environment class provides the most general way of retrieving those paths
• The Application class lives in the System.Windows.Form namespace, which indicates it should only be used for WinForm applications. Other types of applications such as Console and WebForm applications use their corresponding utility classes
  

Microsoft's write-up on this subject can be found at Microsoft API and reference catalog.​

​ public event Action
< connectioninformation > ConnectionProblem;

​​Bad code​​

public event Action
< connectioninformation > ConnectionProblemDetected;

​​Good code

​​​

​ts = TimeSpan.Parse(cboMyComboBox.Text)

Figure: Bad code because a value greater than 24hours will crash eg. 45:30

ts = TimeSpan.Parse(FormatTimeSpanString(cboMyComboBox.Text))​

Figure: Good code because we are using a wrapper method to pre-parse the string containing the 
TimeSpan value. (Look it up in CodeBase)​

We have a program called SSW Code Auditor to check for this rule.

​

Private Sub SomeSubroutine()
'Your code here....
Exit Sub ' Bad code - Writing Exit Sub before End Sub.
End Sub

Bad example​

Private Sub SomeOtherSubroutine()
'Your code here....
End Sub

Good example​

We have a program called SSW Code Auditor to check for this rule.

​

public void SaveUserProfile(
[Optional] string username,
[Optional] string password,
string firstName,
string lastName,
[Optional] DateTime? birthDate)

Figure: Bad Example - Username and Password are optional and first - they are less important than firstName and lastName and should be put at the end

​

public void SaveUserProfile(
string firstName,
string lastName,
[Optional] string username,
[Optional] string password,
[Optional] DateTime? birthDate)

Figure: Good Example - All the optional parameters are the end

Note: When using optional parameters, please be sure to use named para meters

​​Private Sub Command0_Click()
CreateSchedule
End Sub
Sub CreateSchedule()
Dim dteDateStart As Date
Dim dteDateEnd As Date
dteDateStart = Format(Me.ctlDateStart,"dd/mm/yyyy") 'Bad Code - refering the form control directly
dteDateEnd = Format(Me.ctlDateEnd, "dd/mm/yyyy")
.....processing code
End Sub

Bad Example​​

Private Sub Command0_Click()
CreateSchedule(ctlDateStart, ctlDateEnd)
End Sub
Sub CreateSchedule(pdteDateStart As Date, pdteDateEnd As Date)
Dim dteDateStart As Date
Dim dteDateEnd As Date
dteDateStart = Format(pdteDateStart, "dd/mm/yyyy") 'Good Code - refering the parameter directly
dteDateEnd = Format(pdteDateEnd, "dd/mm/yyyy")
&....processing code
End Sub

​Good Example​​

​private void HideToSystemTray()
{
// Hide the windows form in the system tray
if (FormWindowState.Minimized == WindowState)
{
Hide();
}
}

​​​Bad Example: The website where the solution was found IS NOT referenced in the comments

private void HideToSystemTray()
{
// Hide the windows form in the system tray
// I found this solution at http://www.developer.com/net/csharp/article.php/3336751
if (FormWindowState.Minimized == WindowState)
{
Hide();
}
}

Good Example: The website where the solution was found is referenced in the comments​​

​

1. It can be updated easily with normal SQL e.g. Rolling over the current setting to a new value.
   
2. It can be used in joins and in other queries easily without the need to pass in parameters.
3. It can be used to update settings and affect the other applications based on the same database.​​
   

​[TestFixture] public class SqlValidatorReportTest { }

Bad - Unit test class is not suffixed with "Tests"​

[TestFixture] public class HtmlDocumentTests { }  ​

Good - Unit test class is suffixed with "Tests"​

We have a program called SSW Code Auditor to check for this rule.

Instead of:

private void RaiseUpdateOnExistingLotReceived()
{
if (ExistingLotUpdated != null)
{
ExistingLotUpdated();
}
}​

...use this event extension method:

public static void Raise(this EventHandler @event,
object sender, T args) where T : EventArgs
{
var temp = @event;
if (temp != null)
{
temp(sender, args);
}
}
public static void Raise(this Action @event)
{
var temp = @event;
if (temp != null)
{
temp();
}
}

That means that instead of calling:

RaiseExistingLotUpdated();

...you can do:

ExistingLotUpdated.Raise();

Less code = less code to maintain = less code to be blamed for ;)​

​public bool IsValidEmail(string email)
{
// Return true if it is in valid email format.
if (email.IndexOf("@") <= 0) return false;
if (email.EndWith("@")) return false;
if (email.IndexOf(".") <= 0) return false;
if ( ...
}

Figure: Bad example of verify email address​​

public bool IsValidEmail(string email)
{
// Return true if it is in valid email format.
return System.Text.RegularExpressions.Regex.IsMatch( email,
@"^([\w-\.]+)@(([[0-9]{1,3}\.[0-9]{1,3}\.[0-9]{1,3}\.)|(([\w-]+\.)+))([a-zA-Z]{2,4}|[0-9]{1,3})(\]?)$";
}

Figure: Good example of verify email address​​​

public bool IsValidUri(string uri)
{
try 
{ 
Uri testUri = new Uri(uri); 
return true; 
} 
catch (UriFormatException ex)
{ 
return false; 
} 
} 

Figure: Bad example of verifying URI​​​

public bool IsValidUri(string uri) 
{ 
// Return true if it is in valid Uri format.
return System.Text.RegularExpressions.Regex.IsMatch( uri,@"^(http|ftp|https)://([^\/][\w-/:]+\.?)+([\w- ./?/:/;/\%&=]+)?(/[\w- ./?/:/;/\%&=]*)?"); 
} 

Figure: Good example of verifying URI 

You should have unit tests for it, see our Rules to Better Unit Tests for more information.​

Figure: Bad example - "Hard- coded string" works, but is a bad idea

Figure: Good example - Used Enums, looks good and is easy to manage

String strExample = "This is a very long string that is \r\n not properly implementing a new line.";

Bad Example: The string has implemented a manual carriage return line feed pair (\r\n)

String strExample = "This is a very long string that is " + Environment.NewLine +
" properly implementing a new line.";

Good Example: The new line is created with Enviroment.NewLine

​​

Our views on backward compatibility start with asking these questions:

• Question 1: How many apps are we going to break externally?
• Question 2: How many apps are we going to break internally?
• Question 3: What is the cost of providing backward compatibility and repairing (and test) all the broken apps?

Let's look at an example:

We have a public web service /ssw/webservices/postcode/
If we change the URL of this public Web Service, we'd have to answer the questions as follows:

• Answer 1: Externally - Don't know, we have some leads:
  We can look at web stats and get an idea. 
  If an IP address enters our website at this point, it tells us that possibly an application is using it and the user isn't just following the links.
• Answer 2: Website samples + Adams code demo
• Answer 3: Can add a redirect or change the page to output a warning Old URL. Please see www.ssw.com.au/ PostCodeWebService for new URL
  

Because we know that not many external clients use this example, we decide to remove the old web service after some time.

Just to be friendly, we would send an email for the first month, and then another email in the second month.  After that, just emit "This is deprecated (old)."  We'll also need to update the UDDI so people don't keep coming to our old address.

We all wish we never need to support old code, but sometimes the world doesn't go that way, if your answer to question 3 scares you, then you might need to provide some form of backward compatibility or warning.

From: John Liu www.ssw.com.au
To: SSWALL
Subject: Changing LookOut settings

The stored procedure procSSWLookOutClientIDSelect (currently used only by LookOut any version prior to 10) is being renamed to procSSWLookOutClientIDSelect. The old stored procedure will be removed within 1 month.
You can change your settings either by:

• Going to LookOut Options -> Database tab and select the new stored procedure
  
• Upgrading to SSW LookOut version 10.0 which will be released later today
  

​public int Count;

Figure: Bad code. Variable declared as a Field

public int Count
{
get
{
return _count;
}
set
{
_count = value;
}
}

Figure: Good code. Variable declared as a Property​​

We agree that the syntax is tedious and think Microsoft should improve this.​

​Store messages in the Message.resx

Catch(SqlNullValueException sqlex)
{
Response.Write("The value cannot be null.");
}

Bad Example - if you want to change the message, it will cost you lots of time to investigate every try-catch block

Catch(SqlNullValueException sqlex)
{
Response.Write(GetGlobalResourceObject("Messages", "SqlValueNotNull"));
}

Better Example - better than the hard code, but still wordy

Catch(SqlNullValueException sqlex)
{
Response.Write(Resources.Messages.SqlValueNotNull); 'Good Code - storing message in resource file.
} 

Good Example

Module Startup Dim HelloWorld As String = "Hello World!" Sub Main() Console.Write(HelloWorld)Console.Read() End Sub End Module

Bad example of a constant message

Figure: Saving constant message in Resource

Module Startup Sub Main() Console.Write(My.Resources.Messages.Constant_HelloWorld) Console.Read() End Sub End Module

Good example of a constant message

​

​public string myString
{
get
{
return ;
}
}

Figure: Bad code. Low performance​​

public string myString
{
get
{
return string.Empty;
}
}​

Figure: Good code. Higher performance

We have a program called SSW Code Auditor to check for this rule.​

SqlConnection conn = null;
SqlCommand cmd = null;
try
{
conn = new SqlConnection(ConnectionString);
cmd = new SqlCommand(sql, conn);
conn.Open();
cmd.ExecuteNonQuery();
}
catch(SqlException ex)
{
...
}
finally
{
if(cmd!=null)
{cmd.Dispose();}
if(conn!=null)
{conn.Dispose();}
}

Figure: Bad example of dispose of resources

FileStream fs = new FileStream(filePath, FileMode.Open, FileAccess.Read);
StreamReader sr = new StreamReader(fs); 

Figure: Bad example of dispose of resources

​

try
{
using (SqlConnection conn = new SqlConnection(ConnectionString))
{
using (cmd = new SqlCommand(sql, conn))
{
conn.Open();
cmd.ExecuteNonQuery();
conn.Close();
}
}
}
catch(SqlException ex)
{
...
}

Figure: Good example of dispose of resources

using(FileStream fs = new FileStream(filePath, FileMode.Open, FileAccess.Read))
{
using(StreamReader sr = new StreamReader(fs))
{
...
}
}

Figure: Good example of dispose of resources  ​

​

public class WarningEmail
{
//...
public void SendWarningEmail(string pFrom, string pTo, string pCC, string pUser, string pPwd, string pDomain)
{
//...
MailMessage sMessage = new MailMessage();
sMessage.From = new MailAddress(pFrom);
sMessage.To.Add(pTo);
sMessage.CC.Add(pCC);
sMessage.Subject = "This is a Warning";
sMessage.Body = GetWarning();
SmtpClient sSmtpClient = new SmtpClient();
sSmtpClient.Credentials = new NetworkCredential(pUser, pPwd, pDomain);
sSmtpClient.Send(sMessage);
//...
}
}
public class ErrorEmail
{
public void SendErrorEmail(string pFrom, string pTo, string pCC, string pUser, string pPwd, string pDomain)
{
//...
MailMessage sMessage = new MailMessage();
sMessage.From = new MailAddress(pFrom);
sMessage.To.Add(pTo);
sMessage.CC.Add(pCC);
sMessage.Subject = "This is a Error";
sMessage.Body = GetError();
SmtpClient sSmtpClient = new SmtpClient();
sSmtpClient.Credentials = new NetworkCredential(pUser, pPwd, pDomain);
sSmtpClient.Send(sMessage);
//...
}
}

Bad Example: Write the same logic repeatedly

public class WarningEmail
{
//...
public void SendWarningEmail(string pFrom, string pTo, string pCC, string pUser, string pPwd, string pDomain)
{
//...
EmailHelper.SendEmail(pFrom, pTo, pCC, "This is a Warning", GetWarning(), pUser, pPwd, pDomain);
//...
}
}
public class ErrorEmail
{
public void SendErrorEmail(string pFrom, string pTo, string pCC, string pUser, string pPwd, string pDomain)
{
//...
EmailHelper.SendEmail(pFrom, pTo, pCC, "This is an Error", GetError(), pUser, pPwd, pDomain);
//...
}
}
public class EmailHelper
{
public static void SendEmail(string pFrom, string pTo, string pCC, string pSubject, string pBody, string pUser, string pPwd, string pDomain)
{
MailMessage sMessage = new MailMessage();
sMessage.From = new MailAddress(pFrom);
sMessage.To.Add(pTo);
sMessage.CC.Add(pCC);
sMessage.Subject = pSubject;
sMessage.Body = pBody;
SmtpClient sSmtpClient = new SmtpClient();
sSmtpClient.Credentials = new NetworkCredential(pUser, pPwd, pDomain);
sSmtpClient.Send(sMessage);
}
}

Good Example: Put the same logic in a method and make it reusable​

​

Figure: Bad example - "Magic Number" works, but is a bad idea

Figure: Good example - No Magic Number, looks good and is easy to manage​